Fixing a packet trimming counter test failure seen on TH5#24605
Merged
mramezani95 merged 1 commit intoMay 14, 2026
Merged
Conversation
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
mramezani95
added
the
Request for 202511 branch
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kperumalbfn
approved these changes
May 13, 2026
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#1197 |
Collaborator
|
Cherry-pick PR to 202511: #24764 |
12 tasks
Collaborator
|
@mramezani95 cherry pick PR didn't pass PR checker after retry. Please help check! Thanks. ---Powered by SONiC BuildBot
|
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 11, 2026
…24605) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> This PR fixes a test failure in `test_trimming_counters` seen on TH5 devices. Summary: Microsoft ADO ID: 37947965 Fixed a packet trimming counter test failure seen on TH5. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? The last step of `test_trimming_counters` is to block the trim queue and verify trim drop counters. The test does not expect to receive any trimmed packets since the trim queue is blocked. However, TH5 switches cannot completely block egress queues. So the test fails because trimmed packets leak out from the trim queue at a very low rate. #### How did you do it? For TH5 switches, we skip checking that no trimmed packet is captured on the egress port. #### How did you verify/test it? Ran the test on a TH5 device after changes: ``` packet_trimming/test_packet_trimming_symmetric.py::TestPacketTrimmingSymmetric::test_trimming_counters PASSED [100%] ``` #### Any platform specific information? The behavior of the test is only changed for TH5. #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 25, 2026
…24605) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> This PR fixes a test failure in `test_trimming_counters` seen on TH5 devices. Summary: Microsoft ADO ID: 37947965 Fixed a packet trimming counter test failure seen on TH5. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? The last step of `test_trimming_counters` is to block the trim queue and verify trim drop counters. The test does not expect to receive any trimmed packets since the trim queue is blocked. However, TH5 switches cannot completely block egress queues. So the test fails because trimmed packets leak out from the trim queue at a very low rate. #### How did you do it? For TH5 switches, we skip checking that no trimmed packet is captured on the egress port. #### How did you verify/test it? Ran the test on a TH5 device after changes: ``` packet_trimming/test_packet_trimming_symmetric.py::TestPacketTrimmingSymmetric::test_trimming_counters PASSED [100%] ``` #### Any platform specific information? The behavior of the test is only changed for TH5. #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jul 16, 2026
…24605) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> This PR fixes a test failure in `test_trimming_counters` seen on TH5 devices. Summary: Microsoft ADO ID: 37947965 Fixed a packet trimming counter test failure seen on TH5. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? The last step of `test_trimming_counters` is to block the trim queue and verify trim drop counters. The test does not expect to receive any trimmed packets since the trim queue is blocked. However, TH5 switches cannot completely block egress queues. So the test fails because trimmed packets leak out from the trim queue at a very low rate. #### How did you do it? For TH5 switches, we skip checking that no trimmed packet is captured on the egress port. #### How did you verify/test it? Ran the test on a TH5 device after changes: ``` packet_trimming/test_packet_trimming_symmetric.py::TestPacketTrimmingSymmetric::test_trimming_counters PASSED [100%] ``` #### Any platform specific information? The behavior of the test is only changed for TH5. #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
ssithaia-ebay
pushed a commit
to ssithaia-ebay/sflow-yang-sonic-mgmt
that referenced
this pull request
Jul 21, 2026
…24605) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> This PR fixes a test failure in `test_trimming_counters` seen on TH5 devices. Summary: Microsoft ADO ID: 37947965 Fixed a packet trimming counter test failure seen on TH5. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? The last step of `test_trimming_counters` is to block the trim queue and verify trim drop counters. The test does not expect to receive any trimmed packets since the trim queue is blocked. However, TH5 switches cannot completely block egress queues. So the test fails because trimmed packets leak out from the trim queue at a very low rate. #### How did you do it? For TH5 switches, we skip checking that no trimmed packet is captured on the egress port. #### How did you verify/test it? Ran the test on a TH5 device after changes: ``` packet_trimming/test_packet_trimming_symmetric.py::TestPacketTrimmingSymmetric::test_trimming_counters PASSED [100%] ``` #### Any platform specific information? The behavior of the test is only changed for TH5. #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com> Signed-off-by: ssithaia-ebay <ssithaian@ebay.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jul 22, 2026
…24605) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> This PR fixes a test failure in `test_trimming_counters` seen on TH5 devices. Summary: Microsoft ADO ID: 37947965 Fixed a packet trimming counter test failure seen on TH5. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? The last step of `test_trimming_counters` is to block the trim queue and verify trim drop counters. The test does not expect to receive any trimmed packets since the trim queue is blocked. However, TH5 switches cannot completely block egress queues. So the test fails because trimmed packets leak out from the trim queue at a very low rate. #### How did you do it? For TH5 switches, we skip checking that no trimmed packet is captured on the egress port. #### How did you verify/test it? Ran the test on a TH5 device after changes: ``` packet_trimming/test_packet_trimming_symmetric.py::TestPacketTrimmingSymmetric::test_trimming_counters PASSED [100%] ``` #### Any platform specific information? The behavior of the test is only changed for TH5. #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR fixes a test failure in
test_trimming_countersseen on TH5 devices.Summary:
Microsoft ADO ID: 37947965
Fixed a packet trimming counter test failure seen on TH5.
Type of change
Back port request
Approach
What is the motivation for this PR?
The last step of
test_trimming_countersis to block the trim queue and verify trim drop counters. The test does not expect to receive any trimmed packets since the trim queue is blocked. However, TH5 switches cannot completely block egress queues. So the test fails because trimmed packets leak out from the trim queue at a very low rate.How did you do it?
For TH5 switches, we skip checking that no trimmed packet is captured on the egress port.
How did you verify/test it?
Ran the test on a TH5 device after changes:
Any platform specific information?
The behavior of the test is only changed for TH5.
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A